search

ncats / RDAS

5 stars 7 forks source link

Lose our PubMed API query restriction #8

Closed qianzhu2018 closed 11 months ago

qianzhu2018 commented 2 years ago

One review comment from the reviewer: the authors limits to 1000 the amount of PMIDs without explanations. Limit imposed to 1K for all literature 1900-2021 creates the risk to lose important more novel findings. I would suggest to reduce temporal limit to last 50 years (1971-2021) and enhance limits to X (2000?) and see whether there is a gain in information.... Quality first!

wzkariampuzha commented 2 years ago

@devonleadman addressed the 50 year limit here https://github.com/ncats/alert/issues/9 - changed it to a 50 year sliding window

qianzhu2018 commented 2 years ago

Richard has done this task

wzkariampuzha commented 2 years ago

@qianzhu2018 @12yye This issue needs to be linked to a pull request that is reviewed and accepted by someone else for it to be closed.

qianzhu2018 commented 2 years ago

@devonleadman can you work with @12yye to review and close it if all looks good? But let me know anything you need from me

devonleadman commented 2 years ago

@qianzhu2018 Yes i just need @12yye to make a pull request and then ill be able to review it