ncats / lychi

Layered Chemical Identifier
Apache License 2.0
14 stars 10 forks source link

Maven refactor #16

Closed tylerperyea closed 5 years ago

tylerperyea commented 5 years ago

This does 3 things:

  1. Refactors the code to use maven.
  2. Adds some tests that ensure some of the known problem cases work. In particular, it tests for some tricky stereo problems and shuffles the molecules around making sure they get the same hash.
  3. It fixes a bug that existed with some tricky cage-like / bridge-head cases. In particular, this case:

image

Due to symmetry, setting explicit CIP designations on the atoms is not quite possible to do sequentially, but must be done in an explicit order. Alternatively (as is done in this pull request), designations can simply be set twice.