ncats / multiplex-analysis-web-apps

https://ncats.github.io/multiplex-analysis-web-apps/
1 stars 0 forks source link

Import from Mutliplex in Phenotyping Error with '-' in name #53

Open djsmith17 opened 11 months ago

djsmith17 commented 11 months ago

While assigning phenotype names in the multi-axial gating, if a name includes a '-' or '_' then when importing the multi-axial gating into phenotyping, the phenotyper throws an error. Need to work on the parser that finds the marker names.

image

andrew-weisman commented 11 months ago

Thanks @djsmith17, for the time being let's just put a note in the Gater for the user to not include '-''s or '_''s in the phenotype name, it's not worth addressing robustly at this point of getting the MVP out.

Also, are underscores not allowed for sure or is it just hyphens?

djsmith17 commented 11 months ago

I can confirm that it only breaks for dashes (-) and not for underscores (_). I believe there was a mix of both when I tested last time.

andrew-weisman commented 8 months ago

Write more later but should be fixed on 3/[8-9]/24