Makefile: add $(DESTDIR) variable to use GNU make's staged Install

ncbi / amr

AMRFinderPlus - Identify AMR genes and point mutations, and virulence and stress resistance genes in assembled bacterial nucleotide and protein sequence.

https://www.ncbi.nlm.nih.gov/pathogens/antimicrobial-resistance/AMRFinder/

Other

256 stars 34 forks source link

Makefile: add $(DESTDIR) variable to use GNU make's staged Install #131

Closed kbipinkumar closed 9 months ago

kbipinkumar commented 9 months ago

i maintain amrfinder binary package on behalf of Bioarchlinux project

gnu make uses $(DESTDIR) variable so that distro packagers can install files to staging directory using make DESTDIR=${pkgdir} install which then can be packaged into appropriate package file used by distro

currently we are manually patching makefile to add $(DESTDIR) variable prior to compiling. this pull request, if merged, will allow us to avoid manual patching in future releases.

evolarjun commented 9 months ago

Looks reasonable. I'll merge this pull request so it will be included on the master branch, but we won't do a new release that will include it for a little while. Is that a problem for you guys?

kbipinkumar commented 9 months ago

Our build server has already built and packaged the most current release of amrfinder. So the patch being incorporated into a future release as and when it's released is fine.