search

ncbi / ngs-tools

Other
103 stars 25 forks source link

VDB-5087: bitmagick patch #27

Closed oshutov closed 1 year ago

aboshkin commented 1 year ago

@oshutov The change looks OK, but I see a failing test: {noformat} ngs-tools/tools/tax> make test ... 2: Test command: /home/boshkins/ncbi-outdir/ngs-tools/linux/gcc/x86_64/dbg/bin/reader_test
2: Test timeout computed to be: 10000000 2: Running 2 tests 2: Running test fasta_reader 2: /home/boshkins/ncbi/devel/ngs-tools/tools/tax/src/tests/reader_test.cpp:111: void fasta_reader(): Assertion 'f.spotid' == '"SRR1068106.1 1 length=499"' failed. 2: SRR1068106.1 != SRR1068106.1 1 length=499 2/3 Test #2: reader_test ......................Child aborted***Exception: 0.01 sec
... {noformat} All tests pass in engineering. This is on a non-NCBI Ubuntu.

aboshkin commented 1 year ago

Looks good to me. Will merge once we unfreeze engineering, in a few days.