search

ncbi / robotframework-pageobjects

Implementation of the Page Object pattern with Robot Framework and selenium. Also facilitates page object pattern independent of Robot Framework
http://ncbi.github.io/robotframework-pageobjects
Other
84 stars 75 forks source link

Enable selenium grid support#40 #42

Closed s4int closed 9 years ago

kahunacohen commented 9 years ago

Do we need a test for this?

s4int commented 9 years ago

This is just use of capabilities in my opinion even simpler than for sauce.

Testing this can be quite tricky because it requires working selenium grid. You can think about unifying use of capabilities for grid and sauce, then tests can verify passing values.

kahunacohen commented 9 years ago

:+1: Looks good to me. @hellmanj , @frishberg ?

hellmanj commented 9 years ago

Also, it would be great if you could you update the readme with a brief section on using grid.

s4int commented 9 years ago

Ok, I will add short description how to use capabilities.

kahunacohen commented 9 years ago

Please also briefly mention in the README why choose sauce over grid and vice versa. We are pretty unfamiliar with grid.

s4int commented 9 years ago

Basically Sauce Labs is a fancy selenium grid. Grid is simpler and you can run it in your env.

kahunacohen commented 9 years ago

Looks good to me. In the read me we may want to specify these are options related to grid and not necessary for running in sauce. Otherwise looks good. Jared? Daniel?

kahunacohen commented 9 years ago

@hellmanj , @frishberg Are we ok to merge this? Do the option names make sense, or should they be pre-fixed with grid_?

hellmanj commented 9 years ago

It's probably fine for now, we can change later if it's apparent there is any confusion.

kahunacohen commented 9 years ago

OK I am going to reorder the options in the README and merge.

kahunacohen commented 9 years ago

I closed this because I pushed this forked branch to origin. I will open another PR there.