search

ncbi / robotframework-pageobjects

Implementation of the Page Object pattern with Robot Framework and selenium. Also facilitates page object pattern independent of Robot Framework
http://ncbi.github.io/robotframework-pageobjects
Other
84 stars 75 forks source link

Selectors with se2lib keywords #46

Closed dpsfrishberg closed 9 years ago

dpsfrishberg commented 9 years ago

Instead of importing Se2Lib alongside the page class, we let the first page class that inherits from Se2Lib register Se2Lib's keywords. That way, we don't have to have this separate import, and our overridden _element_find is called when you call an Se2Lib keyword, which allows using selectors.

kahunacohen commented 9 years ago

Looks OK to me. It's getting a bit abstract for me to understand well at this point. Looks like there's a failing build though.

kahunacohen commented 9 years ago

Looks like we are taking two screenshots again :) And then there are some browser exited before..

kahunacohen commented 9 years ago

I upped the SE2lib version in requirements.txt.

dpsfrishberg commented 9 years ago

A different test failed because I was using Open Browser without specifying pjs. Just changed that.

hellmanj commented 9 years ago

Great!

kahunacohen commented 9 years ago

:+1: