ncbi / robotframework-pageobjects

Implementation of the Page Object pattern with Robot Framework and selenium. Also facilitates page object pattern independent of Robot Framework
http://ncbi.github.io/robotframework-pageobjects
Other
84 stars 75 forks source link

Test failing due to the mutliple definition of keywords #47

Closed llipavsky closed 9 years ago

llipavsky commented 9 years ago

Hi, after updating to 1.3.0, all tests fail with following:

12-Jun-2015 14:08:30 [ WARN ] Keyword 'Capture Page Screenshot' could not be run on failure: Multiple keywords with name 'Capture Page Screenshot' found. 12-Jun-2015 14:08:30 Give the full name of the keyword you want to use. 12-Jun-2015 14:08:30 Found: 'LoginPage.SafeqLoginPage.Capture Page Screenshot' and 'Selenium2Library.Capture Page Screenshot' 12-Jun-2015 14:08:34 [ WARN ] Keyword 'Capture Page Screenshot' could not be run on failure: Multiple keywords with name 'Capture Page Screenshot' found. 12-Jun-2015 14:08:34 Give the full name of the keyword you want to use. 12-Jun-2015 14:08:34 Found: 'LoginPage.SafeqLoginPage.Capture Page Screenshot' and 'Selenium2Library.Capture Page Screenshot'

Is it possible to somehow handle this on Page level? Or do we have now to rewrite our tests to specify which one we want?

in 1.2.1, there were no issues like this. Thanks

dpsfrishberg commented 9 years ago

Yes, I am seeing this bug as well and working on a fix. Please use version 1.2.1 for now. Thank you for reporting this.

llipavsky commented 9 years ago

Thanks

dpsfrishberg commented 9 years ago

Hi there. The bug is fixed now. Would you mind reinstalling version 1.3.0 (I removed the old one, and the new one is in PyPI now) and running your tests again?

kahunacohen commented 9 years ago

@frishberg maybe a note on the googlegroups robot user group would be good. Since it seems a bunch of people are using this package now. That's good news.

dpsfrishberg commented 9 years ago

Good point, @kahunacohen. Once @llipavsky has confirmed that it works for him, I'll make a note on the user group.

eduardozamin commented 9 years ago

Hello everyone. Thanks for looking into this issue, we are seeing the same problem here.

@frishberg: something seems to be wrong with the package at PyPI. When I run pip install -U robotframework-pageobjects, version 1.2.1 is being installed.

The page at PyPI doesn't list the .tar.gz file for 1.3.0; it looks like it's not there: https://pypi.python.org/pypi/robotframework-pageobjects/1.3.0

(have a look at https://pypi.python.org/pypi/robotframework-pageobjects/1.2.1 for comparison)

llipavsky commented 9 years ago

same for me - so cannot verify

hellmanj commented 9 years ago

Sorry for the hiccup, not sure what went wrong there. We released 1.3.1 (with no changes from 1.3.0) just to make sure we got a good package on PyPI.

eduardozamin commented 9 years ago

Thanks, it can be installed now. I'm running some tests, will post feedback here once I'm done.

eduardozamin commented 9 years ago

Hi @hellmanj, @frishberg,

My tests are failing with the following error:

No keyword with name 'Go To <Page-Name>' found.

I've added a script to reproduce the error here: https://gist.github.com/zamiedu/050bed70ed3a601f5e3a/download

dpsfrishberg commented 9 years ago

OK, I am looking into it now.

dpsfrishberg commented 9 years ago

Everyone, I rolled back to 1.2.1 again. I am working on a fix, but it will require some refactoring and thought, and given other priorities, it may be a few weeks before this feature is released. Meanwhile, please just use 1.2.1. Thank you all for your help debugging.

kahunacohen commented 9 years ago

I think we can close this. The main issue is the implementation of the feature which caused side effects, and thus we rolled back (for now). @frishberg what's the status of being able to use selectors from Robot tests? Did we release that yet?

dpsfrishberg commented 9 years ago

No, we haven't released it yet. Depending on priorities, maybe in the next couple of weeks?

ZiedWD commented 9 years ago

Hello, Any news about the fix for this issue, I am facing this problem now and when downgrading page object lib other tests stop working. Thanks