ncbi / sra-human-scrubber

An SRA tool that takes as input local fastq file from a clinical infection sample, identifies and removes any significant human read, and outputs the edited (cleaned) fastq file that can safely be used for SRA submission.
Other
42 stars 5 forks source link

please version the database #5

Closed pvanheus closed 1 year ago

pvanheus commented 3 years ago

The current database is at https://ftp.ncbi.nlm.nih.gov/sra/dbs/human_filter.db and lacks any identifiable version information. Please provide a database version so that it is possible to know when the DB is updated.

If you could also provide a database "schema" version so that if there is ever a non-backwards compatible update of the DB (so that some versions of the DB can only be used with some versions of the tool), that would also be useful, thanks!

multikengineer commented 2 years ago

Please forgive the tardy reply.

The current database is at https://ftp.ncbi.nlm.nih.gov/sra/dbs/human_filter.db and lacks any identifiable version information. Please provide a database version so that it is possible to know when the DB is updated.

Good suggestion, and when the DB is updated I will version it accordingly.

If you could also provide a database "schema" version so that if there is ever a non-backwards compatible update of the DB (so that some versions of the DB can only be used with some versions of the tool), that would also be useful, thanks!

The database does have a schema version embedded so a non-backwards compatible update will report the non compatible version.

multikengineer commented 1 year ago

Along with release of tag 2.0.0 there is a versioning of the database used (as distinct from the internal schema version). By default the init_db.sh script will pull the current version, and the docker image is built using that same script. See https://ftp.ncbi.nlm.nih.gov/sra/dbs/human_filter/