search

ncbo / bioportal_web_ui

A Rails application for biological ontologies
http://bioportal.bioontology.org/
Other
21 stars 2 forks source link

Project deletion via the Projects page shows erroneous error message #243

Closed jvendetti closed 1 year ago

jvendetti commented 1 year ago

I used the "Delete (admin only)" link to delete a spam project on the Projects page. BioPortal displayed an error message at the top of the page:

Screen Shot 2023-01-11 at 11 47 48 AM


Despite displaying the error message, the project was successfully deleted from the triplestore.

On a related note, there should probably be a confirmation message displayed when the delete link is clicked - something like "are you sure?" - before proceeding with the delete operation.

jvendetti commented 1 year ago

OK - it turns out that the Rails 6.1 upgrade we originally deployed only in staging was accidentally deployed to production on January 5th. The erroneous error messages are a result of changes made to the ontologies_api_ruby_client in this pull request: https://github.com/ncbo/ontologies_api_ruby_client/pull/13.

Syphax has submitted a new pull request that addresses the issues with error responses: https://github.com/ncbo/bioportal_web_ui/pull/240. I'll work on evaluating and getting it deployed.

jvendetti commented 1 year ago

This issue is fixed now that https://github.com/ncbo/bioportal_web_ui/pull/240 is merged / deployed.

Also - I made small repair so that a confirmation dialog is once again displayed for project delete operations (a71a1e4adb7c4aa1c4b152ff69f2bf17d180a487).