search

ncbo / bioportal_web_ui

A Rails application for biological ontologies
http://bioportal.bioontology.org/
Other
21 stars 2 forks source link

Universal Analytics -> Google Analytics 4 migration #271

Closed jvendetti closed 1 year ago

jvendetti commented 1 year ago

Contains the necessary changes to migrate from Universal Analytics to Google Analytics 4. Resolves #270.

@alexskr and I decided to store BioPortal's GA4 measurement ID in encrypted credentials as one way to safeguard against our ID getting inadvertently used by OntoPortal virtual appliance instances.

If appliances want to use GA4, they'll need to add their measurement ID to the relevant credential file:

google_analytics:
  tag_id: G-XXXXXXXXXX
syphax-bouazzouni commented 7 months ago

Hello, feedback on this (6 months after), while merging this to our code base (Agroportal) I figured out that the Google Analytics ID is public, you can see it if you visit the sources of the pages (view-source:https://bioportal.bioontology.org/), not sure on how they verify the provenance as I can just take your analytic ID and put it in my website?

But anyway, as it is publicly available I don't think we should put it as a credential, it makes things just more complicated to update.

jvendetti commented 6 months ago

@alexskr - I'm having trouble remembering the conversation where this was discussed / decided upon:

@alexskr and I decided to store BioPortal's GA4 measurement ID in encrypted credentials as one way to safeguard against our ID getting inadvertently used by OntoPortal virtual appliance instances.

Do you remember the reasoning behind putting this in the credentials file? (See comment from Syphax directly above).

alexskr commented 6 months ago

I don't recall exactly why we decided use encrypted credentials to store google analytics tag but somehow we thought it was reasonable. There is no technical requirement to store it in the encrypted credentials so moving it out should not be a problem.