Subscribe to notes emails button should redirect to login for anonymous users

ncbo / bioportal_web_ui

A Rails application for biological ontologies

http://bioportal.bioontology.org/

Other

21 stars 2 forks source link

Closed jvendetti closed 7 months ago

jvendetti commented 7 months ago

Steps to reproduce:

Navigate to any ontology summary page in BioPortal (make sure you're not logged in)
Navigate to the top-level Notes tab
Click the "Subscribe to notes emails" button

This results in a 500 error from the server because we call the subscriptions endpoint with undefined values, e.g.:

/subscriptions?user_id=undefined&ontology_id=undefined&subbed=undefined

Clicking on the button should redirect to the login page for anonymous users.

jvendetti commented 7 months ago

Additional notes on this button / functionality:

We should display a flash message to indicate whether or not subscription succeeded
If subscription is successful, we need to update the button text immediately. Currently you can only see that the text changed to "Unsubscribe to notes emails" if you reload the page.