search

ncbo / bioportal_web_ui

A Rails application for biological ontologies
http://bioportal.bioontology.org/
Other
21 stars 2 forks source link

/notes/<note_id> page doesn't work as expected #308

Closed alexskr closed 5 months ago

alexskr commented 5 months ago

Notes notifications generate an email containing a link to the UI page that supposed to display that note.

You can respond by visiting: [NCBO BioPortal](http://bioportal.bioontology.org/notes/http%3A%2F%2Fdata.bioontology.org%2Fnotes%2F9393abc0-a8e5-013c-2156-005056010088).

When users click on that link UI responds with an error

syphax-bouazzouni commented 5 months ago

A link that works for notes: http://bioportal.bioontology.org/ontologies/HRAVS/notes/http%3A%2F%2Fdata.bioontology.org%2Fnotes%2F9393abc0-a8e5-013c-2156-005056010088

You need to add the acronym

jvendetti commented 5 months ago

@alexskr - I transferred this issue out of the bioportal_web_ui repository. The body content of new note notifications is generated in this repository in notifications.rb and needs to be fixed here to compose a valid link to the note object.

alexskr commented 5 months ago

@jvendetti, does this mean that /notes endpoint is deprecated in the BioPortal UI?

Notes linked_data model has UI link defined without the ontology in the URL. https://github.com/ncbo/ontologies_linked_data/blob/ec3236a71ff172579923245646d0ea058844794e/lib/ontologies_linked_data/models/notes/note.rb#L23 so we would need to change that as well if /notes endpoint is deprecated in the UI.

jvendetti commented 5 months ago

Apologies @alexskr. I misread something in your initial report. This does belong in bioportal_web_ui, and the issue is in the show method in the NotesController. The notes route isn't deprecated.