search

ncbo / bioportal_web_ui

A Rails application for biological ontologies
http://bioportal.bioontology.org/
Other
21 stars 2 forks source link

Add a natural language selector to the ontology submission form #314

Closed jvendetti closed 3 months ago

jvendetti commented 3 months ago

This pull request adds a YAML file with the ISO 639-1 language codes, makes the codes available via the Rails config object (Rails.application.config.language_codes), and adds a Select2-based natural language selector to the ontology submission form. Resolves #311.

I'm not totally happy with this implementation, but attempts to modernize / align with AgroPortal by adopting the Tom Select library stalled out. See this issue, and this pull request comment for more details. I'd like to revisit this implementation after I have time to sort out blockers to adopting Tom Select.

syphax-bouazzouni commented 3 months ago

Hello @jvendetti, we used this gem https://github.com/xwmx/iso-639, to provide a list of all iso-639-1 languages, with it you will not need to have a local yaml file. If I understood well your need.

jvendetti commented 3 months ago

Modified the pull request to replace the YAML file containing ISO 639-1 language codes with the iso-639 gem.