ncbo / bioportal_web_ui

A Rails application for biological ontologies
http://bioportal.bioontology.org/
Other
21 stars 2 forks source link

Adding proposals results in unnecessary frame reloading #351

Open jvendetti opened 2 hours ago

jvendetti commented 2 hours ago

In the master branch (production environment):

When a user selects any item from the "Add a proposal" dropdown menu and successfully submits a change proposal, the proposal form is hidden and a success message is inserted at the top of the Details pane.

To access this dropdown menu, navigate to the Classes -> Details tab for any ontology where change requests are enabled. For a list of ontologies where change requests are enabled, refer to the change_request YAML file.

In the sync-agroportal branch:

When a user selects any item from the "Add a proposal" dropdown menu and successfully submits a change proposal, the entire content of the right-hand side of the Classes tab is blanked-out and reloaded.

After the reload completes, the proposal form is hidden (as expected) and the success message is displayed (as expected). I don't consider this a show-stopper, but want to document that the code no longer works as I originally designed. The reason I adopted Turbo Streams in this part of the code is to limit page updates to only the areas needed and avoid reloading content that's unaffected by change proposals.

jvendetti commented 2 hours ago

Screen recording that shows current behavior in the master branch:

https://github.com/user-attachments/assets/bfaff6ee-6b0f-44bd-a219-57637849ad21

jvendetti commented 2 hours ago

Screen recording that shows behavior in the sync-agroportal branch:

https://github.com/user-attachments/assets/b1f9b4b5-83a6-44dc-8e11-675e027ff978