`ENM` node and edge counts should be counted after merging imports

ncbo / kg-bioportal

BioPortal, as a Knowledge Graph

https://ncbo.github.io/kg-bioportal/

BSD 3-Clause "New" or "Revised" License

6 stars 0 forks source link

`ENM` node and edge counts should be counted after merging imports #99

Open jmillanacosta opened 1 month ago

jmillanacosta commented 1 month ago

Hi, I came across this project and saw this:

The eNM ontology uses owl imports and you are probably only capturing the ontology annotations.

caufieldjh commented 1 month ago

Hi @jmillanacosta - excellent point! The transforms are not currently doing anything with imports, though the corresponding Bioportal page shows all base and imported classes. There are certainly positives and negatives about including imports, with one positive being that application ontologies like ENM will look much more complete with imports vs. without. In this case I can use one of the alternate serializations of the ontology as they contain the imported classes.

jmillanacosta commented 1 month ago

Hi @caufieldjh, thank you for your explanation, I think that's a good rule of thumb for application ontologies. However, we import a few hundred internally developed classes into the main enanomapper.owl class hierarchy that we would like to see reflected in the KG stats. I can get back to you soon when the next release is out to discuss which subset works better for this KG.