search

ncbo / ncbo_annotator

To automatically process a piece of data text to annotate it with relevant ontology concepts and return the annotations.
http://bioportal.bioontology.org/annotator
Other
18 stars 9 forks source link

Warnings: Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0 #19

Closed jvendetti closed 8 months ago

jvendetti commented 2 years ago

Running unit tests (bundle exec rake test TESTOPTS="-v") I noticed the log is cluttered with instances of the following warning:

Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0.

redis.pipelined do
  redis.get("key")
end

should be replaced by

redis.pipelined do |pipeline|
  pipeline.get("key")
end

(called from /Users/vendetti/.rbenv/versions/2.6.8/lib/ruby/gems/2.6.0/bundler/gems/ncbo_annotator-2725353b0852/lib/ncbo_annotator.rb:446:in `annotate_direct'}
alexskr commented 2 years ago

rack-attack gem needs to be updated to v6.6.1+ which fixes redis deprecation warnings https://github.com/rack/rack-attack/blob/main/CHANGELOG.md#661---2022-04-14