search

ncbo / ncbo_cron

Jobs that run on a regular basis in the NCBO infrastructure
Other
2 stars 6 forks source link

Fix remote pull ontology process for zipped submissions #55

Open syphax-bouazzouni opened 2 years ago

syphax-bouazzouni commented 2 years ago

Bug fix

The do_remote_ontology_pull that fetches and parses new versions of ontologies if found. Does not work for zipped submissions.

It's because before creating a new submission, it checks if OWLAPI can parse the new file. But this test does not work for ZIP/GZIP files.

related

codecov-commenter commented 11 months ago

Codecov Report

Merging #55 (981bc2a) into master (3fef501) will increase coverage by 0.42%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   53.95%   54.38%   +0.42%     
==========================================
  Files          15       15              
  Lines        1214     1210       -4     
==========================================
+ Hits          655      658       +3     
+ Misses        559      552       -7
Flag Coverage Δ
unittests 54.38% <50.00%> (+0.42%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lib/ncbo_cron/ontology_pull.rb 81.89% <50.00%> (+0.22%) :arrow_up:

... and 2 files with indirect coverage changes