ncbo / ncbo_cron

Jobs that run on a regular basis in the NCBO infrastructure
Other
2 stars 6 forks source link

Fix the OBO Foundry synchronization script #79

Closed jvendetti closed 4 months ago

jvendetti commented 4 months ago

Our OBO Foundry synchronization script has been erring out with a JSON::ParserError. This pull request eliminates the use of GitHub GraphQL queries to fetch files form GitHub in favor of using simple HTTP requests. It also adds the faraday and faraday-follow_redirects gems to the gemspec file.

Resolves #78

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 54.92%. Comparing base (252edb2) to head (290c86d).

Files Patch % Lines
lib/ncbo_cron/obofoundry_sync.rb 17.64% 14 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #79 +/- ## =========================================== + Coverage 54.51% 54.92% +0.40% =========================================== Files 16 16 Lines 1240 1229 -11 =========================================== - Hits 676 675 -1 + Misses 564 554 -10 ``` | [Flag](https://app.codecov.io/gh/ncbo/ncbo_cron/pull/79/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ncbo) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ncbo/ncbo_cron/pull/79/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ncbo) | `54.92% <17.64%> (+0.40%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ncbo#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.