ncbo / ontologies_api

Hypermedia API for NCBO's ontology-related projects
http://data.bioontology.org
Other
25 stars 10 forks source link

Fix: Documentation rendering #107

Closed syphax-bouazzouni closed 1 year ago

syphax-bouazzouni commented 1 year ago

The issue

image

And message on the support mailing list

image

The cause

We had this same issue same time ago at Agroportal, so the problem was on the depnedecy haml (that parse our docs) that had a break change after the version 5.2.2, so the solution was to lock the version to 5.2.2 and not use the latest

syphax-bouazzouni commented 1 year ago

FYI @jvendetti , @graybeal

jvendetti commented 1 year ago

Thanks very much for the contribution Syphax. It appears the unit test checks failed due to an issue with the version of ncbo-annotator in the Gemfile.lock:


Step 12/15 : RUN bundle install
 ---> Running in 4ca4c53b2e85
Bundler 2.3.26 is running, but your lockfile was generated with 2.3.11. Installing Bundler 2.3.11 and restarting using that version.
Fetching gem metadata from [https://rubygems.org/.](https://rubygems.org/)
Fetching bundler 2.3.11
Installing bundler 2.3.11
Fetching https://github.com/palexander/shotgun.git
Fetching https://github.com/ncbo/sparql-client.git
Fetching https://github.com/ncbo/ontologies_linked_data.git
Fetching https://github.com/ncbo/ncbo_ontology_recommender.git
Fetching https://github.com/ncbo/ncbo_cron.git
Fetching https://github.com/ncbo/ncbo_annotator.git
fatal: Could not parse object '57204d8e54432ba660af4c49806e2a3019a23fa2'.```
syphax-bouazzouni commented 1 year ago

Thanks very much for the contribution Syphax. It appears the unit test checks failed due to an issue with the version of ncbo-annotator in the Gemfile.lock:

Step 12/15 : RUN bundle install
 ---> Running in 4ca4c53b2e85
Bundler 2.3.26 is running, but your lockfile was generated with 2.3.11. Installing Bundler 2.3.11 and restarting using that version.
Fetching gem metadata from [https://rubygems.org/.](https://rubygems.org/)
Fetching bundler 2.3.11
Installing bundler 2.3.11
Fetching https://github.com/palexander/shotgun.git
Fetching https://github.com/ncbo/sparql-client.git
Fetching https://github.com/ncbo/ontologies_linked_data.git
Fetching https://github.com/ncbo/ncbo_ontology_recommender.git
Fetching https://github.com/ncbo/ncbo_cron.git
Fetching https://github.com/ncbo/ncbo_annotator.git
fatal: Could not parse object '57204d8e54432ba660af4c49806e2a3019a23fa2'.```

Fixed (I hope)

codecov-commenter commented 1 year ago

Codecov Report

Merging #107 (13df5ce) into master (64742d1) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #107   +/-   ##
=======================================
  Coverage   71.83%   71.83%           
=======================================
  Files          52       52           
  Lines        2844     2844           
=======================================
  Hits         2043     2043           
  Misses        801      801           
Flag Coverage Δ
unittests 71.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.