Closed syphax-bouazzouni closed 1 year ago
Merging #114 (ac9a465) into master (373c53e) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #114 +/- ##
=======================================
Coverage 71.84% 71.84%
=======================================
Files 52 52
Lines 2845 2845
=======================================
Hits 2044 2044
Misses 801 801
Flag | Coverage Δ | |
---|---|---|
unittests | 71.84% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@syphax-bouazzouni, somehow I missed your PR and opened https://github.com/ncbo/ontologies_api/issues/116. I didn't mean to step on your toes but I applied another fix, locking redis-store to version 1.9.1 which is the real culprit as far as I could tell.
@syphax-bouazzouni, somehow I missed your PR and opened #116. I didn't mean to step on your toes but I applied another fix, locking redis-store to version 1.9.1 which is the real culprit as far as I could tell.
Yeah, no problem.
Issue
Doing a
bundle update
in themaster
branch, break the test oftest/middleware/test_rack_attack.rb
. Where we get an error ofConnection refused
In those tests, we create in parallel two rack servers in different ports (randomly chosen). But it seems that when we do a
bundle update
it no more work, the servers are not started (or we can't access them)After investigation, I found that the gem
redis
got updated from version4.8.1
to5.0.6
. Going back to the previous version fixed the tests.I didn't luck up what was precisely the breaking change in Redis 5, so I propose to stay with the previous version and pin it.
Changes
4.8.1