search

ncbo / ontologies_api

Hypermedia API for NCBO's ontology-related projects
http://data.bioontology.org
Other
25 stars 10 forks source link

Fix: Bundle update breaks tests because of redis gem new version #114

Closed syphax-bouazzouni closed 1 year ago

syphax-bouazzouni commented 1 year ago

Issue

Doing a bundle update in the master branch, break the test of test/middleware/test_rack_attack.rb. Where we get an error of Connection refused

In those tests, we create in parallel two rack servers in different ports (randomly chosen). But it seems that when we do a bundle update it no more work, the servers are not started (or we can't access them)

After investigation, I found that the gem redis got updated from version 4.8.1 to 5.0.6. Going back to the previous version fixed the tests.

I didn't luck up what was precisely the breaking change in Redis 5, so I propose to stay with the previous version and pin it.

Changes

codecov-commenter commented 1 year ago

Codecov Report

Merging #114 (ac9a465) into master (373c53e) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #114   +/-   ##
=======================================
  Coverage   71.84%   71.84%           
=======================================
  Files          52       52           
  Lines        2845     2845           
=======================================
  Hits         2044     2044           
  Misses        801      801
Flag Coverage Δ
unittests 71.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

alexskr commented 1 year ago

@syphax-bouazzouni, somehow I missed your PR and opened https://github.com/ncbo/ontologies_api/issues/116. I didn't mean to step on your toes but I applied another fix, locking redis-store to version 1.9.1 which is the real culprit as far as I could tell.

syphax-bouazzouni commented 1 year ago

@syphax-bouazzouni, somehow I missed your PR and opened #116. I didn't mean to step on your toes but I applied another fix, locking redis-store to version 1.9.1 which is the real culprit as far as I could tell.

Yeah, no problem.