search

ncbo / ontologies_api

Hypermedia API for NCBO's ontology-related projects
http://data.bioontology.org
Other
25 stars 10 forks source link

Remove redis activesupport #120

Closed alexskr closed 11 months ago

alexskr commented 1 year ago

remove redis-activesupport which was used by rack-attack. Stand-alone redis-activesupport is no longer actively developed and rack-attack can be configured to work without it

redis-rb is upgraded to v5 which resolves https://github.com/ncbo/ontologies_api/issues/105 https://github.com/ncbo/ontologies_api/issues/106

Caveat: redis-client is pinned to a forked version which includes redis-rb v5 compatibility updates.

codecov-commenter commented 1 year ago

Codecov Report

Merging #120 (9e57a68) into develop (90ecfb8) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #120   +/-   ##
========================================
  Coverage    71.86%   71.86%           
========================================
  Files           52       52           
  Lines         2847     2847           
========================================
  Hits          2046     2046           
  Misses         801      801
Flag Coverage Δ
unittests 71.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

alexskr commented 1 year ago

This PR can wait until compatibility issues are resolved for redis-client gem.

alexskr commented 11 months ago

redis-store v1.10 has been finally released so this PR is ready to be merged