search

ncbo / ontologies_api

Hypermedia API for NCBO's ontology-related projects
http://data.bioontology.org
Other
25 stars 10 forks source link

Refactor: Migrate to Minitest 5 and ActiveSupport 5 #143

Open syphax-bouazzouni opened 5 months ago

syphax-bouazzouni commented 5 months ago

Context

This PR updates some gems versions to newer versions, which will help the support ruby >= 3 work (see https://github.com/ncbo/bioportal-project/issues/275)

Changes

alexskr commented 5 months ago

relates to https://github.com/ncbo/ontologies_api/issues/113

alexskr commented 5 months ago

unit tests are failing in GitHub actions for AG but are passing locally. Is this ready for the review?

syphax-bouazzouni commented 5 months ago

unit tests are failing in GitHub actions for AG but are passing locally. Is this ready for the review?

The test failing is related to the order of tests. If you run the test locally with the same seed, you should the see the same errors. image

Didn't figure out, what is the cause for now.

alexskr commented 5 months ago

I wasn't able to reproduce this unit test failure on my end with the seed. Is it failing for you when you run it locally?

jvendetti commented 5 months ago

@alexskr - this is in response to a question you asked above:

Is this ready for the review?

Syphax submitted this pull request in response to a ticket I recently entered that details the difficulties of trying to work with the ontologies_api project in Ruby 3, due to several outdated dependencies. Please note that he characterized the pull request as a starting point in this comment:

... just be aware, that I have not yet found time, to deploy it fully on our side, so take this PR with precaution, but I think at least it is a good starting point to the Minitest migration.

Since Syphax was kind enough to submit a starting point for us, I think the onus should be on the BioPortal team to make a good faith effort to evaluate the code and try working out any issues on our end before asking for his assistance with troubleshooting.

alexskr commented 5 months ago

my intention is not to rush anyone but to state that the unit tests are passing on my end as far as I can tell.

jvendetti commented 5 months ago

It wasn't my intention to imply that you're rushing anyone. Rather, I wanted to make sure Syphax's comments from the other ticket were included here. For anyone looking at this pull request, I thought it should be clear that this hasn't been fully deployed on their side, and may require some extra attention to get it fully integrated on our side.