search

ncbo / ontologies_api

Hypermedia API for NCBO's ontology-related projects
http://data.bioontology.org
Other
25 stars 10 forks source link

test_search_obo_id unit test failures #146

Closed alexskr closed 3 months ago

alexskr commented 3 months ago

unit test fails with latest goo and ontologies_linked_data:

  2) Failure:
TestSearchController#test_search_obo_id [/srv/ontoportal/ontologies_api/test/controllers/test_search_controller.rb:270]:
Failed assertion, no message given.

I think this line assert acr_1 === ncit_acronym || acr_1 === ogms_acronym can be rewritten as assert_includes [ncit_acronym, ogms_acronym], acr_1 to get a better feedback from unit test

if we do that we see more useful error:

  1) Failure:
TestSearchController#test_search_obo_id [/srv/ontoportal/ontologies_api/test/controllers/test_search_controller.rb:270]:
Expected ["NCIT", "OGMS"] to include "CNO".
alexskr commented 3 months ago

ontologies_linked_data PR#143 seems to be the culprit

alexskr commented 3 months ago

unit tests are failing because some of the changes in https://github.com/ncbo/ontologies_linked_data/pull/153 PR were rolled back by https://github.com/ncbo/ontologies_linked_data/pull/143

alexskr commented 3 months ago

addressed in https://github.com/ncbo/ontologies_linked_data/commit/a3f6cf0493bb595011f98acf95efda33111c537b