search

ncbo / ontologies_api_ruby_client

A Ruby client for accessing NCBO's hypermedia api
Other
2 stars 6 forks source link

Tests action isn't working for PRs? #14

Closed syphax-bouazzouni closed 1 year ago

syphax-bouazzouni commented 2 years ago

Hi, Within this repo, I have done three PRs where the tests worked in our forked environments but not here

Example

My latest PR with the same code

In ontoportal-lirmm

image

In NCBO

image

syphax-bouazzouni commented 2 years ago

Maybe the issue is with the UT_APIKEY in the ruby.yml workflow

env:
        UT_APIKEY: ${{ secrets.UT_APIKEY }}

@alexskr any thoughts about this?

alexskr commented 2 years ago

its hard to check whether APIKEY stored in the secrets is bad but I reset it anyway. Are you able to re-run tests on your end?

alexskr commented 1 year ago

With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository so env variable is probably getting set to an empty value. A new extra check should catch this; however, unit test should first validate API key and provide more helpful feedback.

Dependabot pull requests are treated as though they are from a fork which is the reason those are failing as well.

https://stackoverflow.com/questions/58737785/github-actions-empty-env-secrets

syphax-bouazzouni commented 1 year ago

Yeah it works,

image