ncbo / ontologies_api_ruby_client

A Ruby client for accessing NCBO's hypermedia api
Other
2 stars 6 forks source link

Feature: Add the possibility to add a request id #15

Open syphax-bouazzouni opened 1 year ago

syphax-bouazzouni commented 1 year ago

With this PR, you can do now something like this (for example I will take FMA ontology)

ontology.explore.submission(1) # will call https://data.bioontology.org/ontologies/FMA/submissions/1

or

ontology.explore.classes("http://purl.org/sig/ont/fma/fma65139") # will call https://data.bioontology.org/ontologies/FMA/classes/http%3A%2F%2Fpurl.org%2Fsig%2Font%2Ffma%2Ffma65139

(deprecating the single_class: "https://data.bioontology.org/ontologies/FMA/classes/{class_id}" link)

It may sound simple, but was not possible before (as far as I know)

alexskr commented 3 months ago

@syphax-bouazzouni, is this PR up to date and is it safe to merge?

syphax-bouazzouni commented 3 months ago

@syphax-bouazzouni, is this PR up to date and is it safe to merge?

Yes, it is up to date and safe, as it has been in production at Agroportal for 1,5 years.