search

ncbo / ontologies_linked_data

Models and serializers for ontologies and related artifacts backed by 4store
Other
18 stars 8 forks source link

Incorrect tree structure for terms with multiple parents #113

Open mdorf opened 3 years ago

mdorf commented 3 years ago

The tree endpoint does not render correctly for terms that feature multiple parents. Example: "Children's hearing test" term from SNOMEDCT:

Screen Shot 2020-11-17 at 12 16 54 PM Screen Shot 2020-11-17 at 12 18 09 PM

When searching for "Children's hearing test" from SNOMEDCT, the term is displayed, but tree pointing to it is NOT:

http://bioportal.bioontology.org/ontologies/SNOMEDCT/?p=classes

This is due to the fact that the tree REST endpoint picks "Hearing Examination" as the parent for this term, but the term itself is displayed elsewhere (under "Examination of Body System"):

http://data.bioontology.org/ontologies/SNOMEDCT/classes/http%3A%2F%2Fpurl.bioontology.org%2Fontology%2FSNOMEDCT%2F252957005/tree?no_links=true&no_context=true

Screen Shot 2020-11-17 at 12 22 43 PM Screen Shot 2020-11-17 at 12 27 41 PM
mdorf commented 3 years ago

From the user Anna Duncan (MCRI):

A quick FYI (that might help to track the issue down):

  • Our team have been looking up terms extensively over the last few weeks and only really noticed this issue in the last 48 hours (Monday our time)
  • I don’t recall it occurring last Wednesday (our time, and the last time I used the system), especially not the error messages when trying to load
  • My colleague used the system on Friday and, when looking up photograph, remembers not being able to see it in the tree, much like the children’s hearing test below, but did not receive any error messages like Monday
  • If something was changed in the coding that renders the tree mid-late last week your time, I’d say that is where the culprit is