search

ncbo / ontologies_linked_data

Models and serializers for ontologies and related artifacts backed by 4store
Other
18 stars 8 forks source link

Feature: Get the correct type for skos concepts #162

Closed syphax-bouazzouni closed 2 months ago

syphax-bouazzouni commented 1 year ago

Issue

If we take as an example the NLMVS ontology, which is SKOS terminology with only SKOS Concepts (no OWL ontology)

But when we check one of its concepts like Intraspinal abscess (disorder) , our API tell us that is of @type: "owl:Class" (see screenshot below)

image

This PR fix that, by displaying the correct type, skos:Concept if SKOS and owl:Class if Ontology

After

image
codecov[bot] commented 1 year ago

Codecov Report

Merging #162 (81c7977) into master (b5057b4) will decrease coverage by 0.02%. The diff coverage is 70.00%.

:exclamation: Current head 81c7977 differs from pull request most recent head ba7a7f8. Consider uploading reports for the commit ba7a7f8 to get more accurate results

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
- Coverage   80.75%   80.72%   -0.03%     
==========================================
  Files          63       63              
  Lines        4848     4857       +9     
==========================================
+ Hits         3915     3921       +6     
- Misses        933      936       +3
Flag Coverage Δ
unittests 80.72% <70.00%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/ontologies_linked_data/serializers/json.rb 79.22% <70.00%> (-1.67%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

alexskr commented 2 months ago

already implemented via PR #199 https://github.com/ncbo/ontologies_linked_data/commit/36a5b68c38a02e0b221ba7b7bfc1169dc14ea01f