search

ncbo / ontologies_linked_data

Models and serializers for ontologies and related artifacts backed by 4store
Other
17 stars 8 forks source link

use max_depth calculated by owlapi_wrapper for UMLS ontologies #182

Closed alexskr closed 5 months ago

alexskr commented 5 months ago

Get max depth from the metrics.csv file which is already generated by owlapi_wrapper when new submission of UMLS ontology is created. Ruby code/sparql for calculating max_depth fails for large UMLS ontologie with AllegroGraph backend

Addresses #181

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ec25d0e) 80.76% compared to head (bee7779) 80.04%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #182 +/- ## =========================================== - Coverage 80.76% 80.04% -0.72% =========================================== Files 63 63 Lines 4917 4917 =========================================== - Hits 3971 3936 -35 - Misses 946 981 +35 ``` | [Flag](https://app.codecov.io/gh/ncbo/ontologies_linked_data/pull/182/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ncbo) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ncbo/ontologies_linked_data/pull/182/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ncbo) | `80.04% <100.00%> (-0.72%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ncbo#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alexskr commented 5 months ago

code coverage went down for lib/ontologies_linked_data/metrics/metrics.rb because ruby/sparql code is no longer used for calculating metrics. That code should be removed eventually.