ncbo / ontologies_linked_data

Models and serializers for ontologies and related artifacts backed by 4store
Other
18 stars 8 forks source link

refactor notification #184

Closed alexskr closed 8 months ago

alexskr commented 8 months ago

notification refactor follow up to https://github.com/ncbo/ontologies_linked_data/pull/148

In order to clarify the distinction between the OntoPortal site admins and ontology owners/admins the following settings and methods are renamed:

LinkedData.setting.admin_emails is renamed to ontoportal_admin_emails LinkedData::Utils::Notifier.admin_mails -> ontology_admin_emails LinkedData::Utils::support_mails -> ontoportal_admin_emails LinkedData::Utils::notify_support_grouped -> notify_ontoportal_admins_grouped

alexskr commented 8 months ago

@syphax-bouazzouni please review the follow up changes and let me know if there is anything that should be tweaked in order to fit your code base

codecov[bot] commented 8 months ago

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (4b6b7f4) 80.76% compared to head (d0b6ad8) 80.66%. Report is 4 commits behind head on develop.

:exclamation: Current head d0b6ad8 differs from pull request most recent head 87afcc4. Consider uploading reports for the commit 87afcc4 to get more accurate results

Files Patch % Lines
lib/ontologies_linked_data/utils/notifications.rb 61.97% 27 Missing :warning:
lib/ontologies_linked_data/utils/notifier.rb 94.82% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #184 +/- ## =========================================== - Coverage 80.76% 80.66% -0.10% =========================================== Files 63 64 +1 Lines 4917 5337 +420 =========================================== + Hits 3971 4305 +334 - Misses 946 1032 +86 ``` | [Flag](https://app.codecov.io/gh/ncbo/ontologies_linked_data/pull/184/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ncbo) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ncbo/ontologies_linked_data/pull/184/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ncbo) | `80.66% <76.92%> (-0.10%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ncbo#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.