Closed alexskr closed 8 months ago
@syphax-bouazzouni please review the follow up changes and let me know if there is anything that should be tweaked in order to fit your code base
Attention: 30 lines
in your changes are missing coverage. Please review.
Comparison is base (
4b6b7f4
) 80.76% compared to head (d0b6ad8
) 80.66%. Report is 4 commits behind head on develop.:exclamation: Current head d0b6ad8 differs from pull request most recent head 87afcc4. Consider uploading reports for the commit 87afcc4 to get more accurate results
Files | Patch % | Lines |
---|---|---|
lib/ontologies_linked_data/utils/notifications.rb | 61.97% | 27 Missing :warning: |
lib/ontologies_linked_data/utils/notifier.rb | 94.82% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
notification refactor follow up to https://github.com/ncbo/ontologies_linked_data/pull/148
In order to clarify the distinction between the OntoPortal site admins and ontology owners/admins the following settings and methods are renamed:
LinkedData.setting.admin_emails is renamed to ontoportal_admin_emails LinkedData::Utils::Notifier.admin_mails -> ontology_admin_emails LinkedData::Utils::support_mails -> ontoportal_admin_emails LinkedData::Utils::notify_support_grouped -> notify_ontoportal_admins_grouped