search

ncbo / ontologies_linked_data

Models and serializers for ontologies and related artifacts backed by 4store
Other
17 stars 8 forks source link

Notifications: ontology processing notification sends out misleading email about failed archived submission #185

Closed alexskr closed 5 months ago

alexskr commented 5 months ago

PR https://github.com/ncbo/ontologies_linked_data/pull/184 and https://github.com/ncbo/ontologies_linked_data/pull/148 restored new ontology submission processing notifications. When new submission is processed OntoPortal sends two notifications: 1 Success: image 2: Failure for archived image

Archive notification gets incorrectly flagged as a failure because archived submission is no longer ready. The second notification about archived submission should not be send out because it might confuse users and I don't think users are interested in getting that information in the first place.

syphax-bouazzouni commented 5 months ago

Here is a commit that we did at Agroportal to fix that https://github.com/ontoportal-lirmm/ontologies_linked_data/pull/116/commits/6af858ab82cb386cc11f29451842f42a5d5104cb

You can copy the fix if it is good for you

alexskr commented 5 months ago

Thanks @syphax-bouazzouni, https://github.com/ncbo/ontologies_linked_data/commit/602a44cbe83ff13d304650f3c4352497d0071a8a fixed the issue with the notifications about archived submissions.
However, do users even need to know that the previous submission was archived?

alexskr commented 5 months ago

relates to https://github.com/ncbo/bioportal-project/issues/291