search

ncbo / ontologies_linked_data

Models and serializers for ontologies and related artifacts backed by 4store
Other
17 stars 8 forks source link

Merge Develop to Master, release v5.28.0 #187

Closed alexskr closed 5 months ago

alexskr commented 5 months ago

Changes:

codecov[bot] commented 5 months ago

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (4b6b7f4) 80.76% compared to head (5900570) 79.96%. Report is 9 commits behind head on master.

:exclamation: Current head 5900570 differs from pull request most recent head 1e8bd29. Consider uploading reports for the commit 1e8bd29 to get more accurate results

Files Patch % Lines
lib/ontologies_linked_data/utils/notifications.rb 61.97% 27 Missing :warning:
lib/ontologies_linked_data/utils/notifier.rb 94.82% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #187 +/- ## ========================================== - Coverage 80.76% 79.96% -0.80% ========================================== Files 63 64 +1 Lines 4917 4957 +40 ========================================== - Hits 3971 3964 -7 - Misses 946 993 +47 ``` | [Flag](https://app.codecov.io/gh/ncbo/ontologies_linked_data/pull/187/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ncbo) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ncbo/ontologies_linked_data/pull/187/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ncbo) | `79.96% <78.41%> (-0.80%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ncbo#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jvendetti commented 5 months ago

The screenshot below was provided as an example of the notification that an ontology owner receives after a successful processing. The text of "Parsed successfully" directly followed by "Obsolete" is confusing, and I believe will generate traffic on our support list from users asking what this means. I object to releasing this in production without addressing this.

Screenshot 2024-02-09 at 11 35 39 AM

alexskr commented 5 months ago

obsolete submission status in the REST API is associated with determining obsolete classes and properties. Including this status in email notification can create some confusion so it should not be included in the email notification ..

alexskr commented 5 months ago

The screenshot below was provided as an example of the notification that an ontology owner receives after a successful processing. The text of "Parsed successfully" directly followed by "Obsolete" is confusing, and I believe will generate traffic on our support list from users asking what this means. I object to releasing this in production without addressing this.

addressed by https://github.com/ncbo/ontologies_linked_data/commit/c77d0b390e19c394989e9467e447fcc653b53fa5