Open jvendetti opened 2 months ago
Attention: Patch coverage is 0%
with 8 lines
in your changes are missing coverage. Please review.
Project coverage is 80.13%. Comparing base (
604e5cb
) to head (bd2ad7f
).
Files | Patch % | Lines |
---|---|---|
lib/ontologies_linked_data/utils/notifications.rb | 0.00% | 8 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
great idea! This will definitely help tidy up the code.
I've noticed that some non-Rails projects store .erb files in the templates directory, though I'm uncertain if it offers any clarity over using the views directory.
Templates would also be a good name for the directory
I recently had to figure out why the OBO Foundry synchronization script was failing, along with the synchronization report that's supposed to go out via email at script completion. While looking at code in the Notifications class, I was bothered by the proliferation of heredocs and gsubbing. I propose using ERB templates to represent the notification bodies, and this pull request implements one example:
views/emails
directory for the body of the OBO Foundry synchronization reportobofoundry_sync
method to set the necessary variables and instantiate / complete the template