ncbo / ontologies_linked_data

Models and serializers for ontologies and related artifacts backed by 4store
Other
17 stars 8 forks source link

Feature: Multilingual Support - Add search and languages serialization #199

Closed syphax-bouazzouni closed 2 months ago

syphax-bouazzouni commented 2 months ago

Require

Context

This PR, implements mostly two things:

See the added units tests, for examples.

Changes

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 71.55812% with 345 lines in your changes are missing coverage. Please review.

Project coverage is 78.10%. Comparing base (299a01c) to head (fc48343). Report is 116 commits behind head on develop.

Files Patch % Lines
...ion_process/operations/submission_rdf_generator.rb 55.33% 184 Missing :warning:
...ubmission_process/operations/submission_indexer.rb 60.97% 48 Missing :warning:
lib/ontologies_linked_data/utils/notifications.rb 61.11% 28 Missing :warning:
lib/ontologies_linked_data/serializers/json.rb 65.71% 12 Missing :warning:
...ocess/operations/submission_mertrics_calculator.rb 83.33% 12 Missing :warning:
lib/ontologies_linked_data/models/class.rb 83.07% 11 Missing :warning:
lib/ontologies_linked_data/metrics/metrics.rb 33.33% 8 Missing :warning:
...rocess/operations/submission_properties_indexer.rb 82.60% 8 Missing :warning:
...tologies_linked_data/models/ontology_submission.rb 64.28% 5 Missing :warning:
...ervices/submission_process/submission_processor.rb 91.93% 5 Missing :warning:
... and 10 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #199 +/- ## =========================================== - Coverage 80.80% 78.10% -2.71% =========================================== Files 63 74 +11 Lines 4907 5370 +463 =========================================== + Hits 3965 4194 +229 - Misses 942 1176 +234 ``` | [Flag](https://app.codecov.io/gh/ncbo/ontologies_linked_data/pull/199/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ncbo) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ncbo/ontologies_linked_data/pull/199/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ncbo) | `78.10% <71.55%> (-2.71%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ncbo#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.