Closed Sinderella closed 6 years ago
Hey @Sinderella ,
Thanks again for the contribution.
The only comment I have is that I would call the getCurrentAutoRepeater()
method getSelectedAutoRepeater()
and I'm pretty sure you can simplify the body of that method to:
public AutoRepeater getSelectedAutoRepeater() {
return ((AutoRepeaterTabHandle) mainTabbedPane.getTabComponentAt(mainTabbedPane.getSelectedIndex())).autoRepeater;
}
Now that I look at that code I should probably have made the AutoRepeater that the AutoRepeaterTabHandle holds private and made a getter but whatever.
Everything else looks great! I look forward to merging this.
Thanks, Justin
Hello @justinmoore,
I have finished working on this PR. Let me know if you need me to make any change, else we can close #28. 😆
Cheers, Thanat
Everything looks great, I'll merge this in a minute.
Thanks! Justin
A new dedicated class has been created to deal with all the menu actions. Some code has been remove during the process.
@justinmoore I am not finished with this PR as you can see in the task list above. I'd like to see what is your feedback in terms of the coding style and how I structure the code. It is my first time contributing to an open source project, and I never had experience dealing with swing before, so I am not certain if it is the right pattern that I am using in this commit.