search

nccgroup / AutoRepeater

Automated HTTP Request Repeating With Burp Suite
https://www.nccgroup.trust/us/about-us/newsroom-and-events/blog/2018/january/autorepeater-automated-http-request-repeating-with-burp-suite/
MIT License
846 stars 107 forks source link

Added ability to duplicate replacements, log filters, and log hightli… #54

Closed danielthatcher closed 5 years ago

danielthatcher commented 5 years ago

Added a button under the add, edit, and remove buttons to duplicate entries. This fixes #53 and adds the same ability for replacements.

danielthatcher commented 5 years ago

Since this PR being merged would cause there being two buttons which apply to the selected item (edit and duplicate), it might make sense to move them to a right click menu.

justinmoore commented 5 years ago

Hey @danielthatcher,

Thanks for the pull request, I'll merge this and rebuild the JAR. I was considering moving a feature like this into a right click menu, however, burp uses "Duplicate" buttons in the Macros menu and some other spots so I figure it's fine to leave it as a button.

Thanks, Justin

justinmoore commented 5 years ago

Hey @danielthatcher,

Just a quick follow up, there was a bug with your implementation that I just ironed out. You duplicated the reference to the object, not the object itself. This means that the duplicated items would all get updated when one was updated. I implemented copy constructors for all the objects which deep copy the duplicate items and initialize a new object. Again, thanks for the pull request. I don't think this feature would have been added in any reasonable amount of time otherwise.

Thanks, Justin