nccgroup / GTFOBLookup

Offline command line lookup utility for GTFOBins (https://github.com/GTFOBins/GTFOBins.github.io), LOLBAS (https://github.com/LOLBAS-Project/LOLBAS), WADComs (https://wadcoms.github.io), and HijackLibs (https://hijacklibs.net/).
GNU General Public License v3.0
253 stars 40 forks source link

Use $XDG_CACHE_HOME instead of script location for storing the LOLBAS / GTFOBins repos. #1

Closed tritoke closed 4 years ago

tritoke commented 4 years ago

This is only a small change but using $XDG_CACHE_HOME/gtfoblookup to store the LOLBAS / GTFOBins repos means that the program can be installed locally, e.g. to $HOME/.local/bin and it won't clutter the install directory. As well as this, using a standard cache dir allows users to clear their cache easily.

JamesConlan96 commented 4 years ago

This has been rejected in order to maintain compatibility with the Windows OS.

tritoke commented 4 years ago

Thanks for letting me know, I hadn't considered compatibility with windows while writing the patch.

On Tue, May 19, 2020, 08:54 JamesConlan96 notifications@github.com wrote:

This has been rejected in order to maintain compatibility with the Windows OS.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nccgroup/GTFOBLookup/pull/1#issuecomment-630651020, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIKSSQKQ67TQ73J52H62XALRSI3KFANCNFSM4NEIUZIQ .

lllama commented 4 years ago

FYI the appdirs python package allows you to support appropriate directories platforms

JamesConlan96 commented 4 years ago

The appdirs package has now been used to store repos in cache directories.