nccgroup / LoggerPlusPlus

Advanced Burp Suite Logging Extension
GNU Affero General Public License v3.0
630 stars 157 forks source link

Row height does not scale with font #212

Open ldionmarcil opened 5 months ago

ldionmarcil commented 5 months ago

Description: On a fresh Burp install on Linux, the height of rows is much too small relative to the font size, making it unreadable. Might be a regression from https://github.com/nccgroup/LoggerPlusPlus/issues/2

Steps To Reproduce: Open logger++ and browse a little.

Expected behavior: The rows are adapted to the height of the font size.

Screenshots: image

Version: 3.20.1, downloaded from Github

ldionmarcil commented 5 months ago

I think it has something to do with my DPI settings, although I disabled it in Burp. As a workaround for now, I simply increased the size of each rows to 45.

diff --git a/src/main/java/com/nccgroup/loggerplusplus/logview/logtable/LogTable.java b/src/main/java/com/nccgroup/loggerplusplus/logview/logtable/LogTable.java
index 98048a6..bd68f50 100644
--- a/src/main/java/com/nccgroup/loggerplusplus/logview/logtable/LogTable.java
+++ b/src/main/java/com/nccgroup/loggerplusplus/logview/logtable/LogTable.java
@@ -44,7 +44,7 @@ public class LogTable extends JTable

         this.setTableHeader(controller.getTableHeader()); // This was used to create tool tips
         this.setAutoResizeMode(JTable.AUTO_RESIZE_OFF); // to have horizontal scroll bar
-        this.setRowHeight(20); // As we are not using Burp customised UI, we have to define the row height to make it more pretty
+        this.setRowHeight(45); // As we are not using Burp customised UI, we have to define the row height to make it more pretty
         this.setDefaultRenderer(Boolean.class, new BooleanRenderer()); //Fix grey checkbox background
         ((JComponent) this.getDefaultRenderer(Boolean.class)).setOpaque(true); // to remove the white background of the checkboxes!

image