Missing args in AWSScout2/rules/data/rulesets/default.json

nccgroup / Scout2

Security auditing tool for AWS environments

http://nccgroup.github.io/Scout2/

GNU General Public License v2.0

1.73k stars 300 forks source link

Missing args in AWSScout2/rules/data/rulesets/default.json #257

Closed benghaun closed 6 years ago

benghaun commented 6 years ago

For the default rulesets json file, the "vpc-subnet-with-default-acls.json" rule seems to be missing arguments. Looking at vpc-subnet-with-default-acls.json in AWSScout2/rules/data/findings shows that it expects 2 arguments, which are [ "Direction of traffic (ingress or egress)", "Corresponding target (source or destination)" ].

x4v13r64 commented 6 years ago

Correct, nice find - I'll fix this soon. Will also lower from Danger to Warning.

Additionally I'm seeing that in the subnet view, you don't see what ACL is actually associated to the subnet (you have to go in the ACL view to find associated subnets). Will consider adding this.