search

nccgroup / Scout2

Security auditing tool for AWS environments
http://nccgroup.github.io/Scout2/
GNU General Public License v2.0
1.73k stars 300 forks source link

How to add rationale to all the rules for Iam? #285

Closed challs1 closed 5 years ago

challs1 commented 6 years ago

I would like to add all the rationales for the rules in Iam . When I am trying add rationales in the source code and running the ui still it was showing n/a? Is there any way to get rid of n/a and to keep rationale for all the rules in the IAM

l01cd3v commented 6 years ago

Once you've edited the JSON rules under AWSScout2/rules/data/findings and added a rationale attribute, you'll need to run the tool again to get this data picked up in the report. A local run will be much faster as it won't call the AWS APIs but rathe use the previously-fetched data.

./Scout2.py --profile <name> --local

challs1 commented 6 years ago

@l01cd3v I did it but in the ui dashboard still it was fetching the same old report without rationales.

x4v13r64 commented 6 years ago

First of all thank you @challs1, this would be a nice improvement - please do submit a PR once this is implemented.

Did you manage to get this to show up in your report? You can also try to start from scratch if the above did not work.

challs1 commented 6 years ago

@j4v Sure i will be doing it in a couple of days. Rightnow I am validation once it is done completely i will do a pr

x4v13r64 commented 6 years ago

@challs1 do you still plan on contributing this?

challs1 commented 5 years ago

Yeah sure I will submit the pr

On Sat, Sep 29, 2018 at 12:07 AM Xavier Garceau-Aranda < notifications@github.com> wrote:

@challs1 https://github.com/challs1 do you still plan on contributing this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nccgroup/Scout2/issues/285#issuecomment-425616495, or mute the thread https://github.com/notifications/unsubscribe-auth/Al9XVhgEFaeRlXHXe3TtPC6pHDNzp8W3ks5ufv_6gaJpZM4V-Xra .

x4v13r64 commented 5 years ago

Closing due to inactivity. If you do plan on improving issue rationale please open a PR at https://github.com/nccgroup/ScoutSuite.