nccgroup / ScoutSuite

Multi-Cloud Security Auditing Tool
GNU General Public License v2.0
6.76k stars 1.07k forks source link

fixed possible FPs for some GCP instances checks when 'true' is capitalized #1658

Open halfluke opened 4 months ago

halfluke commented 4 months ago

Description

Make sure the PR is against the develop branch (see Contributing).

Make sure to set the corresponding milestone in the PR. Sorry, I am not sure what this is...

During a GCP assessment, I noticed that SS was reporting some false positives for "block project-wide ssh keys". I identified the problem in the fact that in the GCP project, some values were reported in capital "TRUE", while SS only checks for "true". Code fixed to handle both cases, also for "OS login enabled" and "serial port enabled", just in case.

Fixes # (issue) I don't think there is an open issue for this.

Type of change

Select the relevant option(s):

Checklist: