nccgroup / ScoutSuite

Multi-Cloud Security Auditing Tool
GNU General Public License v2.0
6.75k stars 1.07k forks source link

SyntaxWarning from regexes in ScoutSuite/providers/utils.py #1680

Open ckuethe opened 1 week ago

ckuethe commented 1 week ago

Describe the bug

While running scoutsuite (commit bb0c98357d53fd3ceb637ac919a147e2f81e47cf) with python 3.12.3 I got a bunch of these warnings.

ScoutSuite/providers/utils.py:137: SyntaxWarning: invalid escape sequence '\-'
  re.compile("(adobe[a-z0-9_ .\-,]{0,25})(=|>|:=|\|\|:|<=|=>|:).{0,5}['\"]([a-f0-9]{32})['\"]"),

The scan completed but I don't like SyntaxWarnings. I'm filing this bug so that I can reference it in a PR (#1681) that fixes it. :)

To Reproduce

scout aws -p aws_target --report-dir ~/scoutsuite/aws_target

There's nothing special about my AWS configuration, I set up my account as documented on https://github.com/nccgroup/ScoutSuite/wiki/Amazon-Web-Services

Additional context

gy8879 commented 1 week ago

we are students majoring in computer science. can we take it?

ckuethe commented 6 days ago

@gy8879 you don't need my permission to use this patch; I'm contributing this because ScoutSuite has been useful for me and I hope this makes ScoutSuite a little more useful for others.

Back when I was in university they didn't care too much which sources I used, as much they wanted me to properly cite them.

You'd have to ask your instructors if using GPL software is allowed in their courses but there's nothing in the GPL that says you can't use it for educational purposes.

gy8879 commented 6 days ago

thx 😀