This commit is the exact commit from @PsychoPast in PR#6, but adds the fix for the issue commented upon there.
Strictly speaking it doesn't just fix the issue in main which incapacitated the MSVC code path, but also adds two other fixes.
IDAPython in IDA 8.3 complains about find_text being deprecated in favor of ida_search.find_text. Additionally the EAs of the vtables were trimmed by one hex digit.
I'd suggest to use f-strings where possible in the future, but I'll only put in the work if one of the project owners deems this worthwhile as well.
PS: was a little difficult to scrape the original commit from this repo, but I managed it and added my minor changes on top. So this obviates the need for PR#6, if merged.
nguigo
commented
1 year ago
This commit is the exact commit from @PsychoPast in PR#6, but adds the fix for the issue commented upon there.
Strictly speaking it doesn't just fix the issue in
mainwhich incapacitated the MSVC code path, but also adds two other fixes.IDAPython in IDA 8.3 complains about
find_textbeing deprecated in favor ofida_search.find_text. Additionally the EAs of the vtables were trimmed by one hex digit.I'd suggest to use f-strings where possible in the future, but I'll only put in the work if one of the project owners deems this worthwhile as well.
PS: was a little difficult to scrape the original commit from this repo, but I managed it and added my minor changes on top. So this obviates the need for PR#6, if merged.