search

nccgroup / autochrome

This tool downloads, installs, and configures a shiny new copy of Chromium.
Apache License 2.0
449 stars 80 forks source link

Bumped autochrome_junk_drawer to manifest v3 #33

Open mephesto1337 opened 2 years ago

mephesto1337 commented 2 years ago

It now uses declarativeNetRequestWithHostAccess which 'statically' modifies requests with rules (useragenttag$COLOR.json) depending on the theme currently loaded. It also needs the management permission in order to determine which profile/theme is currently being used.

As manifest v2 will stop working during 2023, it seems to me as a good time to upgrade.

peter-h-ncc commented 1 year ago

Can you provide a link to details of manifest v2 being deprecated for documentation purposes? This looks like a change that I should merge sooner rather than later, any documentation is appreciated.

mephesto1337 commented 1 year ago

Hello, here is the link : https://developer.chrome.com/docs/extensions/mv3/mv2-sunset/. Its deprecation has been a bit postponed. It seems than in early 2024 (the date is still under review), extensions using the v2 manifest will stop working.

mephesto1337 commented 1 year ago

I should also note that I had to had a new custom header x-autochrome-tag. The new API does not allow modifying headers (only, add, delete and set). So I "set" the User-Agent with a fixed version of chrome and added the new header. If a breaking change has to happened, both headers should be present for some time I think.