nccgroup / aws-inventory

Discover resources created in an AWS account.
Apache License 2.0
707 stars 128 forks source link

route53 list_resource_record_sets not called #15

Open t-rojan opened 6 years ago

t-rojan commented 6 years ago

Hi - I noticed that the gui file exports include route53 hosted zones but do not include results of calls to list_resource_record_sets for reach hosted zone. I am guessing because of the way that aws-inventory enumerates APIs that it hasn't figured out that this API can be called if the right parameters are provided. I am sure there are other APIs that are not getting called because of similar issues. Is there a solution to this that I've missed, or suggestions on how to get the resource records included?

bitsandsalsa commented 6 years ago

Currently, the tool ignores APIs that require args.

That specific API list-resource-record-sets does indeed require a hosted-zone-id argument. This feature is on the TODO list, but implementing it would require significant work. The service models that botocore interprets can get us this information. Without this feature, I don't see a sane way to even single out certain APIs you want to provide args for.

Just spitballing here, but you could take in some list from the user that specifies 2 things: what APIs their after and where to find values to use as args. The "where" could be used as keys into the response data store which is just a big dictionary. But now you have a dependency problem if the data isn't yet there from an earier API that hasn't been called yet.

ncc-erik-steringer commented 4 years ago

Cleaning out issues. It looks like this is a larger-scale feature to add. What I'm thinking is some sort of dependency system that can: