search

nccgroup / blackboxprotobuf

Blackbox Protobuf is a set of tools for working with encoded Protocol Buffers (protobuf) without the matching protobuf definition.
MIT License
516 stars 86 forks source link

fixed some bugs #10

Closed irsdl closed 2 years ago

irsdl commented 2 years ago

callbacks variable was not defined in some places which has been fixed (not sure why self did not contain it in jython)

replacing saving with loading for import

supporting more headers for protobuf

rwinkelmaier-ncc commented 2 years ago

Thanks for the bug fixes! I probably copy-pasted the error handler and forgot to add the callbacks object (or to try and grab it from a parent), should probably be more consistent about that.

Think I was originally trying to be conservative about matching content-types, but in hindsight, I think it's definitely better to be more aggressive there, not much harm if it fails.

irsdl commented 2 years ago

brilliant. Could you please send an email to PortSwigger to add it to BApp Store? See https://portswigger.net/bappstore for more info

rwinkelmaier-ncc commented 2 years ago

Haven't started the process yet, but should soon. A big goal for rewriting the UI was to try and get it more usable before submitting to the BApp store.