search

nccgroup / blackboxprotobuf

Blackbox Protobuf is a set of tools for working with encoded Protocol Buffers (protobuf) without the matching protobuf definition.
MIT License
516 stars 86 forks source link

consider supporting protobuf 4.x #25

Closed curoky closed 10 months ago

curoky commented 11 months ago

the latest 3.x version is 3.20.3 released at 2022.9.30.

image
image
rwinkelmaier-ncc commented 11 months ago

Hi,

Last time I looked, I ran into some errors trying to bump the version to 4.X, but haven't dug into it a lot yet. I can take another stab at it, but wondering if it might be time to drop the dependency altogether.

rwinkelmaier-ncc commented 11 months ago

It looks like the core tests (eg. varint and message encoding) still run fine, so might not be too hard to fix the tests and upgrade. I'll look into it.

Neverbolt commented 10 months ago

Would also love protobuf 4.X support!

In the meantime I install bbpb and then do a pip install --no-warn-conflicts protobuf==4.21.1, it's very much not pretty, will not work for everybody, but works for me atm

rwinkelmaier-ncc commented 10 months ago

Hi all,

I was able to test with the v4 of protobuf and I think it works fine, it had just broken some tests.

However, it seemed easier to just drop the protobuf dependency entirely than set up tests across multiple dependency versions. I think that will also have some other benefits down the road.

You should now be able to install bbpb version 1.1.0 along side any protobuf version (or without protobuf at all). Tests are all passing, but let me know if you run into any issues.