Few small changes based on what I saw in my first couple runs of the application after building from then-current source:
The project currently lacks a .gitignore file, which in a clean git environment results in all Visual Studio user files (.suo, etc.) and compiled source being marked by git as new files. I added a basic list of such Visual Studio files, a few compiled file extensions and the folders the builds typically live in, and some OS-specific files such as the evil Thumbs.db file in Windows.
The current VersionCheck.cs does a straight string-comparison against the remote copy stored on GitHub, considering the application outdated if the strings do not match. As the current code is marked as 1.1.0.0, and the Version.Check/Version.txt file currently shows 1.0.0.0, the application should not indicate that it is outdated.
My changes remove the string-comparison in favor of a simple regular expression which expects the four-section version numbers currently used, with a two-stage comparison against each section. My manual tests correctly indicated the following: 1.0.0.0 < 1.1.0.0, 1.0.9.0 < 1.1.0.0, 1.23.45.67 < 2.0.0.0, etc.
olliencc
commented
11 years ago
Few small changes based on what I saw in my first couple runs of the application after building from then-current source:
The project currently lacks a .gitignore file, which in a clean git environment results in all Visual Studio user files (.suo, etc.) and compiled source being marked by git as new files. I added a basic list of such Visual Studio files, a few compiled file extensions and the folders the builds typically live in, and some OS-specific files such as the evil Thumbs.db file in Windows.
The current VersionCheck.cs does a straight string-comparison against the remote copy stored on GitHub, considering the application outdated if the strings do not match. As the current code is marked as 1.1.0.0, and the Version.Check/Version.txt file currently shows 1.0.0.0, the application should not indicate that it is outdated. My changes remove the string-comparison in favor of a simple regular expression which expects the four-section version numbers currently used, with a two-stage comparison against each section. My manual tests correctly indicated the following:
1.0.0.0 < 1.1.0.0,1.0.9.0 < 1.1.0.0,1.23.45.67 < 2.0.0.0, etc.