Pass in role_arn and external_id as environment variables

nccgroup / opinel

Python code shared by Scout2 and AWS-Recipes

GNU General Public License v2.0

24 stars 18 forks source link

Closed therealnb closed 5 years ago

therealnb commented 6 years ago

Similar in spirit to #25, I would like to be able to pass in role_arn and external_id as environment variables.

The use case is calling scout2 from another process. It is a bit hacky to rewrite configs on the fly (which is how we have been doing it).

I plan to write the code and submit a PR myself if this is ok - are there any steps I need to take first? Or shall I just go ahead and submit the PR?

therealnb commented 6 years ago

I made a PR for this change. Please let me know if there is anything else I need to do or if you want it changed.

For reference, we would like to use this code in production, so sooner rather than later would be better.

Many thanks

x4v13r64 commented 5 years ago