search

nccgroup / opinel

Python code shared by Scout2 and AWS-Recipes
GNU General Public License v2.0
24 stars 18 forks source link

Split on correct divider in AWS Credential file #8

Closed breadtk closed 8 years ago

breadtk commented 8 years ago

Currently Opinel relies on the fact that there may be a space before an access/secret key within the ~/.aws/credentials file (e.g. "aws_access_key_id = AKI..." The official package however does support defining attributes without space separation. This commit thus supports this use case.

breadtk commented 8 years ago

Also FWIW I decided not to edit "mfa_serial" and "security_token" as I had not had a chance to test it out, though I would assume editing those in a similar fashion would also work.

micksmix commented 8 years ago

:+1:

l01cd3v commented 8 years ago

Thanks ! I'll do the same changes for the session token and mfa serial.

l01cd3v commented 8 years ago

session tokens may actually contain equal signs, working on a fix...

l01cd3v commented 8 years ago

Just published version 0.19.3, which includes this fix

breadtk commented 8 years ago

Awesome possum. Thanks.